chore(logger): clear prev request buffers in manual mode #3742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
documentation
dreamorosi
changed the title
|
E2e tests for this branch are green: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/13947131658 I'm requesting both @am29d and @leandrodamascena review on this one on purpose, thank you. |
am29d
approved these changes
Mar 19, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
The PR updates the default behavior of the log buffering feature in the Logger utility to clear existing buffers whenever creating the buffer for a new request. This was already the case when using the class method decorator and the Middy.js middleware.
This PR aligns the behavior also for manual mode, aka when customers are not using either of the two patterns above. This will help reduce the likelihood that customers forget to clear log buffers and risk exhausting the memory available in the sandbox.
The PR also adds an additional item to the feature FAQs to document how the Logger calculates the size of each log entry. This should address questions from customers on the topic, which came in from early adopters.
Issue number: closes #3705
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.